Re: [PATCH] GROUP BY ALL - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] GROUP BY ALL
Date
Msg-id 4083063.1758902694@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] GROUP BY ALL  (David Christensen <david@pgguru.net>)
Responses Re: [PATCH] GROUP BY ALL
List pgsql-hackers
David Christensen <david@pgguru.net> writes:
> Here is a rebased version with a few more tests.  I also changed the
> main check here to using `!contain_agg_clause` instead of
> `!IsA(Aggref))` directly.  (This was defined in `optimizer/clauses.h`,
> but we already are pulling in `optimizer.h`, so it felt valid to me.)

contain_agg_clause will blow up on a SubLink, so I doubt this is
gonna be robust.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: test_json_parser/002_inline is kind of slow
Next
From: David Christensen
Date:
Subject: Re: [PATCH] GROUP BY ALL