Postgres Pro
Downloads
Home   >   mailing lists

Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; " - Mailing list pgsql-jdbc

From Christopher BROWN
Subject Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; "
Date
Msg-id CAHL_zcOUvRFBAttQSnRiOPqk8RFocq-dCMO3FOyrJ1OUZyQh-Q@mail.gmail.com
Whole thread Raw
In response to Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; "  (Dave Cramer <pg@fastcrypt.com>)
Responses Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; "
List pgsql-jdbc
Tree view
Hello,

Developers that use the driver via a framework (open-source, in-house) might not be in a position to change SQL, compared with developers that are able to modify hand-written SQL, so it's probably best to tolerate it by discarding any trailing semi-colon (with or without any trailing whitespace) in the parser.

I've also encountered coding practices (coding-style "standards") where semi-colons are expected (some people just love terminating all statements, not just Java, with semi-colons, even when it's not strictly necessary (e.g.: JavaScript).

So, my preference would be to maintain backwards-compatibility for others, even if I don't have such an issue myself.

--
Christopher


On 7 October 2015 at 14:34, Dave Cramer <pg@fastcrypt.com> wrote:
This is a very good question, but lots of people cut and paste SQL into code ... sometimes the ; gets in there.

Behaviour of previous version is important, but in this case It may not be justified.

Anyone else have an opinion ?

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 7 October 2015 at 08:30, Vladimir Sitnikov <sitnikov.vladimir@gmail.com> wrote:
I wonder why pgjdbc would want to silently ignore that user error?
Is "behavior of previous version" a sole justification?

I've drafted https://github.com/pgjdbc/pgjdbc/pull/386 to cover that.

Vladimir


pgsql-jdbc by date:

Previous
From: Dave Cramer
Date:
Subject: Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; "
Next
From: Leonardo Frittelli
Date:
Subject: Connection terminated by the server causes deadlock in jdbc client side connection