Postgres Pro
Downloads
Home   >   mailing lists

Reassign variable value in XLogReadRecord - Mailing list pgsql-hackers

From Dickson S. Guedes
Subject Reassign variable value in XLogReadRecord
Date
Msg-id CAHHcrepdu9f5nmn3wYV4UeZY7YdGAApTGX3qzbn-zCFVhVHddA@mail.gmail.com
Whole thread Raw
Responses Re: Reassign variable value in XLogReadRecord
List pgsql-hackers
Tree view 
Hello,

While walking in the code I see the following code in
src/backend/access/transam/xlogreader.c:177-191

XLogRecord *
XLogReadRecord(XLogReaderState *state, XLogRecPtr RecPtr, char **errormsg)
{XLogRecord *record;XLogRecPtr    targetPagePtr;bool        randAccess = false;  <=== assignuint32        len,
 total_len;uint32        targetRecOff;uint32        pageHeaderSize;bool        gotheader;int            readOff;
 
randAccess = false;  <== reassign/* reset error state */


Do I am missing something or the last one is unnecessary?

Best regards.
-- 
Dickson S. Guedes
mail/xmpp: guedes@guedesoft.net - skype: guediz
http://github.com/guedes - http://guedesoft.net
http://www.postgresql.org.br

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)
Next
From: Brendan Jurd
Date:
Subject: Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)