Re: [COMMITTERS] pgsql: Logical replication support for initial data copy - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [COMMITTERS] pgsql: Logical replication support for initial data copy
Date
Msg-id CAHGQGwHtFDdu7ZStgg1UNB0vxzDt49nEjjkn85ODUiM1EyN7CQ@mail.gmail.com
Whole thread Raw
List pgsql-hackers
On Thu, Mar 23, 2017 at 9:59 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Logical replication support for initial data copy

+ case T_SQLCmd:
+ if (MyDatabaseId == InvalidOid)
+ ereport(ERROR,
+ (errmsg("not connected to database")));

This error message doesn't seem to follow the error message style in docs.
Also It seems a bit unclear to me. So what about replacing it with
something like the following?
   ERROR:  must connect to database to execute command \"%s\"

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
Next
From: "Daniel Verite"
Date:
Subject: Re: PATCH: Batch/pipelining support for libpq