Re: Missing comment block at the top of streamutil.h and receivelog.h - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Missing comment block at the top of streamutil.h and receivelog.h
Date
Msg-id CAHGQGwHW8JZN_S8ZBC-cgj__RBRAbSsBPzGHQ1TzTu0344R=YQ@mail.gmail.com
Whole thread Raw
In response to Re: Missing comment block at the top of streamutil.h and receivelog.h  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Missing comment block at the top of streamutil.h and receivelog.h
List pgsql-hackers
On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander <magnus@hagander.net> wrote:
>> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> Probably that's a good idea, but do we really need Author: tags?  I
>>> know we have those in a few places, but certainly not everywhere, and
>>> as time goes by they tend to be less accurate reflections of who wrote
>>> the latest code (as opposed to the original code).  Furthermore, every
>>> time we include them, it tends to increase the demand to add even more
>>> of them because, hey, everybody likes to be acknowledged.
>>
>> Given that I'm the one named in it - nah, just drop it.
> Updated patch updated without any Author tag.

I think that it's better to add an include guard like

#ifndef RECEIVELOG_H
#define RECEIVELOG_H
...
#endif

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: Similar to csvlog but not really, json logs?
Next
From: Tom Lane
Date:
Subject: Re: Similar to csvlog but not really, json logs?