Re: Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover
Date
Msg-id CAHGQGwH46S5LaTs_ULAngFyAGsvbya98At70N=vp-Bc7b5d3aQ@mail.gmail.com
Whole thread Raw
In response to Re: Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Prevent restored WAL files from being archived again Re: Unnecessary WAL archiving after failover  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On Sat, Aug 11, 2012 at 2:19 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> On Thu, Aug 9, 2012 at 8:08 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> On 29 July 2012 16:01, Fujii Masao <masao.fujii@gmail.com> wrote:
>>
>>> Attached patch changes the startup process so that it creates .done file
>>> whenever WAL file is successfully restored, whether archive mode is
>>> enabled or not. The restored WAL files will not be archived again because
>>> of .done file.
>>
>> The proposed patch works, for archiving only, but I don't like the
>> code. It's a partial refactoring of existing code.
>>
>> I prefer to go for a full re-factoring version for HEAD, and a zero
>> refactoring version for 9.2 since we're deep into beta.

Isn't it time to push the full re-factoring version to HEAD? If there is no
such version yet, what about pushing the zero refactoring version for now?

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: Incorrect behaviour when using a GiST index on points
Next
From: Pavel Stehule
Date:
Subject: review: pgbench - aggregation of info written into log