Re: Proposal : REINDEX xxx VERBOSE - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Proposal : REINDEX xxx VERBOSE
Date
Msg-id CAHGQGwGsd1avJdY2nEAGcx4urd5jJJpg60Ha3y9y7gJSTzMYPg@mail.gmail.com
Whole thread Raw
In response to Re: Proposal : REINDEX xxx VERBOSE  (Sawada Masahiko <sawada.mshk@gmail.com>)
List pgsql-hackers
On Thu, May 14, 2015 at 4:30 PM, Sawada Masahiko <sawada.mshk@gmail.com> wrote:
> On Thu, May 14, 2015 at 9:58 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> On Wed, May 13, 2015 at 8:25 PM, Sawada Masahiko <sawada.mshk@gmail.com> wrote:
>>> The v15 patch emits a line for each table when reindexing multiple
>>> tables, and emits a line for each index when reindexing single table.
>>> But v14 patch emits a line for each index, regardless of reindex target.
>>> Should I change back to v14 patch?
>>
>> Uh, maybe.  What made you change it?
>>
>
> I thought that the users who want to reindex multiple tables are
> interested in the time  to reindex whole table takes.
> But I think it seems sensible to emit a line for each index even when
> reindex multiple tables.
> The v16 patch is based on v14 and a few modified is attached.

Thanks for updating the patch!

The regression test failed because you forgot to remove the trailng period
from the verbose message in the "expected file" of the regression test.
I just fixed it and push the patch.

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Arjen Nienhuis
Date:
Subject: Re: Patch for bug #12845 (GB18030 encoding)
Next
From: Simon Riggs
Date:
Subject: Re: feature freeze and beta schedule