Re: pgsql: Add pg_stat_archiver statistics view. - Mailing list pgsql-committers

On Tue, Feb 4, 2014 at 6:20 AM, Andres Freund <andres@2ndquadrant.com> wrote:
> Hi,
>
>
> On 2014-01-28 17:59:12 +0000, Fujii Masao wrote:
>> Add pg_stat_archiver statistics view.
>>
>> This view shows the statistics about the WAL archiver process's activity.
>>
>> Gabriele Bartolini, reviewed by Michael Paquier, refactored a bit by me.
>
> As coverity notest the following lines of code:
>         if (archiver_stats->last_failed_wal == 0)
>                 nulls[4] = true;
>         else
>                 values[4] = CStringGetTextDatum(archiver_stats->last_failed_wal);
> won't work as intended since last_failed_wal is an array of chars and
> thus will never be 0 (which should be NULL if so).

Thanks for the report! I found last_archived_wal has also the same
problem. Fixed.

Regards,

--
Fujii Masao