On Fri, May 9, 2014 at 1:06 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Thu, May 8, 2014 at 9:47 PM, Christoph Berg <cb@df7cb.de> wrote:
>> Re: Andres Freund 2014-05-08 <20140508145901.GB1703@awork2.anarazel.de>
>>> > Maybe this is nitpicking, but what happens when postgresql.auto.conf also
>>> > includes the setting of data_directory? This is possible because we can
>>> > set data_directory via ALTER SYSTEM now. Should we just ignore such
>>> > problematic setting in postgresql.auto.conf with warning message?
>>>
>>> I think that's a case of "Doctor, it hurts when I do this. Doctor: don't
>>> do that then".
>>
>> I'd opt to forbid setting data_directory at ALTER SYSTEM time. For the
>> other options, I agree with Andres that you should get to keep all
>> parts if you manage to break it.
>
> There is no harm in forbidding data_directory, but similarly we can
> imagine that people can set some very large values for some config
> variables due to which later it can have symptoms similar to this
> issue.
Yes, that can prevent the server from restarting at all. In this case,
to restart the server, we need to edit postgresql.auto.conf manually
and remove the problematic settings though the header of
postgresql.auto.conf warns "Do not edit this file manually!".
Regards,
--
Fujii Masao
