Re: The problems of PQhost() - Mailing list pgsql-hackers

On Fri, Nov 28, 2014 at 3:43 AM, Noah Misch <noah@leadboat.com> wrote:
> On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
>> On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch <noah@leadboat.com> wrote:
>> > Sure.  I'll first issue "git revert 9f80f48", then apply the attached patch.
>> > Since libpq ignores a hostaddr parameter equal to the empty string, this
>> > implementation does likewise.  Apart from that, I anticipate behavior
>> > identical to today's code.
>>
>> +                fprintf(stderr, _("out of memory\n"));
>>
>> psql_error() should be used instead of fprintf()?
>
> I copied what pg_malloc() would do.  Either way seems reasonable.

psql_error() seems better for the case where psql executes the
specified input file.
In this case, psql_error reports the message in the format like
"psql:filename:lineno: message".

Regards,

-- 
Fujii Masao