Postgres Pro
Downloads
Home   >   mailing lists

Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial) - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)
Date
Msg-id CAHGQGwFv-LUQGcwHs3j33io3CXvNRO2CXn19hqR8rzJHsC0moQ@mail.gmail.com
Whole thread Raw
In response to Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Memory leak with XLogFileCopy since de768844 (WAL file with .partial)  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view 
On Mon, Jun 8, 2015 at 11:52 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Jun 5, 2015 at 10:45 PM, Fujii Masao wrote:
>> Why don't we call InstallXLogFileSegment() at the end of XLogFileCopy()?
>> If we do that, the risk of memory leak you're worried will disappear at all.
>
> Yes, that looks fine, XLogFileCopy() would copy to a temporary file,
> then install it definitely. Updated patch attached.

Thanks for updating the patch! Looks good to me. Applied.

Regards,

-- 
Fujii Masao

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Dependency between bgw_notify_pid and bgw_flags
Next
From: Andres Freund
Date:
Subject: Re: [CORE] back-branch multixact fixes & 9.5 alpha/beta: schedule