Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: pg_basebackup (missing exit on error) - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: PATCH: pg_basebackup (missing exit on error)
Date
Msg-id CAHGQGwFrnPMhpJZT31J4JtCfSrMJfvgtESQVkjXxHhROd0A3Eg@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: pg_basebackup (missing exit on error)  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, Mar 28, 2012 at 9:40 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> I think it would make sense to rearrange that so that we don't have
> two tests for ztarfile != NULL; do that test first, and then if it
> fails, do the strcmp after that.

Makes sense.

> Also, if we're going to test the return value of fclose(), shouldn't
> we also be checking the return value of gzclose()?

Yes, we should.

Attached patch does the above two changes.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)
Next
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] pgsql: pg_test_timing utility, to measure clock monotonicity and timing