Re: Arithmetic operators for macaddr type - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Arithmetic operators for macaddr type
Date
Msg-id CAHGQGwFoppCsM6zOs9gHcWiFvLUvbqKGm7ek9PX_Nd-i13E86g@mail.gmail.com
Whole thread Raw
In response to Re: Arithmetic operators for macaddr type  (Brendan Jurd <direvus@gmail.com>)
Responses Re: Arithmetic operators for macaddr type  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Dec 13, 2011 at 2:16 PM, Brendan Jurd <direvus@gmail.com> wrote:
> On 12 December 2011 15:59, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>> 2011/12/12 Brendan Jurd <direvus@gmail.com>:
>>> I just bumped into a situation where I wanted to do a little macaddr
>>> arithmetic in postgres.  I note that the inet type has support for
>>> bitwise AND, OR and NOT, as well as subtraction, but macaddr has none
>>> of the above.
>>
>> +1
>>
>
> Here is a patch for $SUBJECT.  I merely added support for ~, & and |
> operators for the macaddr type.  The patch itself is rather trivial,
> and includes regression tests and a doc update.

The patch looks fine except that it uses the OIDs already used in pg_proc.h.
Attached is the updated version of the patch, which fixes the above problem.

> For the documentation, I did think about adding a new table for the
> macaddr operators, but in the end decided it would probably be an
> overkill.

Agreed.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Should we add crc32 in libpgport?
Next
From: Heikki Linnakangas
Date:
Subject: Re: foreign key locks, 2nd attempt