Re: Re: reloption to prevent VACUUM from truncating empty pages atthe end of relation - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Re: reloption to prevent VACUUM from truncating empty pages atthe end of relation
Date
Msg-id CAHGQGwFkAnB6MKhDih15=JBn=HgyLSEJnXZHzosgao8B7wUTOA@mail.gmail.com
Whole thread Raw
In response to Re: Re: reloption to prevent VACUUM from truncating empty pages atthe end of relation  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Re: reloption to prevent VACUUM from truncating empty pages atthe end of relation
Re: reloption to prevent VACUUM from truncating empty pages at theend of relation
List pgsql-hackers
On Sat, Apr 6, 2019 at 2:04 AM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Thu, Apr 4, 2019 at 9:19 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > As INDEX_CLEANUP option has been added by commit a96c41f, the new
> > option for this feature could also accept zero or one boolean
> > argument, that is SHRINK_TABLE [true|false] and true by default.
> > Explicit options on VACUUM command overwrite options set by
> > reloptions. And if the boolean argument is omitted the option depends
> > on the reloptions.
>
> Yes, I think that's how it should work, because that's how the other
> option works, and there's no compelling reason to be consistent.
>
> My preference is for "truncate" over "shrink".

+1

Attached is the updated version of the patch.
I just replaced "shrink" with "truncate" and rebased the patch
on the master. I'm thinking to commit this patch at first.
We can change the term and add the support of "TRUNCATE" option
for VACUUM command later.

Regards,

-- 
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Cleanup/remove/update references to OID column
Next
From: Masahiko Sawada
Date:
Subject: Re: Re: reloption to prevent VACUUM from truncating empty pages atthe end of relation