Re: [COMMITTERS] pgsql: Add missing format attributes - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [COMMITTERS] pgsql: Add missing format attributes
Date
Msg-id CAHGQGwFVb8VsfA+H75+XcNMb6tGtRxEz4gW4BHzMhk2j9J92dA@mail.gmail.com
Whole thread Raw
Responses Re: [COMMITTERS] pgsql: Add missing format attributes
List pgsql-hackers
On Sun, Sep 11, 2011 at 5:17 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Add missing format attributes
>
> Add __attribute__ decorations for printf format checking to the places that
> were missing them.  Fix the resulting warnings.  Add
> -Wmissing-format-attribute to the standard set of warnings for GCC, so these
> don't happen again.
>
> The warning fixes here are relatively harmless.  The one serious problem
> discovered by this was already committed earlier in
> cf15fb5cabfbc71e07be23cfbc813daee6c5014f.

This commit causes the following warning at the compile time.

error.c: In function 'ecpg_raise_backend':
error.c:339: warning: field precision should have type 'int', but
argument 2 has type 'long unsigned int'

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [REVIEW] prepare plans of embedded sql on function start
Next
From: Pavel Stehule
Date:
Subject: Re: [REVIEW] prepare plans of embedded sql on function start