avoid unnecessary failure to open restored WAL files - Mailing list pgsql-hackers

From Fujii Masao
Subject avoid unnecessary failure to open restored WAL files
Date
Msg-id CAHGQGwFSb=JSgvz5Ru3R=MjoR6oN43mYcQOCeHSXyE9rSgRQJg@mail.gmail.com
Whole thread Raw
Responses Re: avoid unnecessary failure to open restored WAL files
List pgsql-hackers
Hi,

In HEAD and 9.2, the following scenario happens in archive recovery.

1. The archived WAL file is restored onto the temporary file name
"RECOVERYXLOG".
2. The restored WAL file is renamed to the correct file name like
000000010000000000000002.
3. The startup process tries to open the temporary file even though
it's already been renamed
    and doesn't exist. This always fails.
4. The startup process retries to open the correct file as a WAL file
in pg_xlog directory instead
    of the archived file. This succeeds.

The above failure of file open is unnecessary, so I think we can avoid
that. Attached patch
changes the startup process so that it opens the correct restored WAL
file after restoring the
archived WAL file.

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Reminder: 9.2beta3 wraps tonight
Next
From: "Kevin Grittner"
Date:
Subject: Re: WIP Patch: Use sortedness of CSV foreign tables for query planning