Re: pg_receivexlog add synchronous mode - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_receivexlog add synchronous mode
Date
Msg-id CAHGQGwEeQR=P1OPX5mgEpYhbWgVHeBz+ytH4-n7V2eaJx7qorg@mail.gmail.com
Whole thread Raw
In response to Re: pg_receivexlog add synchronous mode  (<furuyao@pm.nttdata.co.jp>)
Responses Re: pg_receivexlog add synchronous mode
List pgsql-hackers
On Tue, Jul 29, 2014 at 7:07 PM,  <furuyao@pm.nttdata.co.jp> wrote:
> I have improved the patch  by making following changes:
>
> 1. Since stream_stop() was redundant, stream_stop() at the time of WAL file closing was deleted.
>
> 2. Change the Flash judging timing for the readability of source code.
>    I have changed the Flash judging timing , from the continuous message after receiving to
>    before the feedbackmassege decision of continue statement after execution.

Thanks for the updated version of the patch!

While reviewing the patch, I found that HandleCopyStream() is still
long and which decreases the readability of the source code.
So I feel inclined to refactor the HandleCopyStream() more for better
readability. What about the attached refactoring patch?

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: psql: show only failed queries
Next
From: Fujii Masao
Date:
Subject: Re: pg_receivexlog add synchronous mode