Request a Demo
Home   >   mailing lists

Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date
Msg-id CAHGQGwEYsmVotxXs2-c7-qOBbpH1Xad+m=Xed_hWeboF3ziJgQ@mail.gmail.com
Whole thread Raw
In response to Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Dec 23, 2025 at 2:05 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> Thanks, the idea looks good now. One minor comment:

Thanks for the review!

>   }
> +
>   /*
>
> This appears to be an unnecessary addition in the patch.

The added blank line is due to pgindent, so I didn't exclude it from the patch.
I'm not sure what the preferred practice is for handling pgindent changes
in older branches, but in general it seems better to keep the code clean
and pgindent-compliant even there. Thoughts?

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Next
From: Kirill Reshke
Date:
Subject: Re: Fix typos: 'Bejing' to 'Beijing' in partition regress/docs