Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect - Mailing list pgsql-hackers

On Sat, Dec 20, 2025 at 12:48 AM Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> On Fri, 19 Dec 2025 at 19:42, Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Fri, Dec 19, 2025 at 9:30 PM Kirill Reshke <reshkekirill@gmail.com> wrote:
> > > I checked the new TAP test 0002 changes. I am wondering, why are
> > > connection options validated so late in this test? I mean,  we do
> > > ALTER PUBLICATION, then we restart publisher, wait for catchup, check
> > > alter publication, and etc, and only then we look if connection
> > > options are indeed applied?
> >
> > Are you suggesting testing whether the conninfo setting is applied earlier,
> > for example, right after both running ALTER SUBSCRIPTION CONNECTION and
> > confirming that the logical replication connection is re-established?
> > Yeah, that might be better and would also make the test easier to read.
> >
> > Regards,
> >
> > --
> > Fujii Masao
>
> Yes, exactly

OK, I've updated the 0002 patch accordingly.

Regards,

--
Fujii Masao