Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect
Date
Msg-id CAA4eK1KgdCs3Z=RnmacxOBX7_jTz8nQRERBXKJYv3v-u3zWF4Q@mail.gmail.com
Whole thread Raw
In response to Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Thu, Dec 25, 2025 at 12:31 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Tue, Dec 23, 2025 at 2:05 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > Thanks, the idea looks good now. One minor comment:
>
> Thanks for the review!
>
> >   }
> > +
> >   /*
> >
> > This appears to be an unnecessary addition in the patch.
>
> The added blank line is due to pgindent, so I didn't exclude it from the patch.
>

Fair enough.

> I'm not sure what the preferred practice is for handling pgindent changes
> in older branches, but in general it seems better to keep the code clean
> and pgindent-compliant even there.
>

+1.

--
With Regards,
Amit Kapila.



pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Can we remove support for standard_conforming_strings = off yet?
Next
From: Amit Kapila
Date:
Subject: Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.