Re: pg_resetxlog to clear backup start/end locations. - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_resetxlog to clear backup start/end locations.
Date
Msg-id CAHGQGwEPGBofDOxkocw8wgVFmCBH4ToJ4z1hTf3Bvd4FNE6UVw@mail.gmail.com
Whole thread Raw
In response to Re: pg_resetxlog to clear backup start/end locations.  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: pg_resetxlog to clear backup start/end locations.  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
List pgsql-hackers
On Fri, Jun 27, 2014 at 12:29 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, I have finished the patches for all of 9.x.
>
>> I dont' touch what '-n' option shows and rewrite documents for
>> the option a bit. And '-n' won't show the changes of backup
>> location.
>
> -8.4: does not have backup locations in ControlFileData.
>
> 9.0-9.1: resetxlog_backuploc_9_0-9.1.patch: Add clearance of backupStartPoint.
>
> 9.2: resetxlog_backuploc_9_2.patch: Add clearance of
>            backupStart/EndPoint and backupEndRequired
>
> 9.3: resetxlog_backuploc_9_3.patch: Ditto. (format of XLogRecPtr changed)
>
> 9.4-master: resetxlog_backuploc_9_4-master.patch: Add clearance of
>            backupPoints. help message and html doc changed.

Thanks for the patch! But when I read the source code of pg_resetxlog,
I found that it has already reset the backup locations. Please see
RewriteControlFile() which does that. So I wonder if we need nothing
at least in HEAD for the purpose which you'd like to achieve. Thought?

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Index-only scans and non-MVCC snapshots
Next
From: Dilip kumar
Date:
Subject: Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ]