Re: REPACK (CONCURRENTLY) might keep dropped-column data - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: REPACK (CONCURRENTLY) might keep dropped-column data
Date
Msg-id CAHGQGwE7bE944nqv4VnwSq9GFYs-4bz203+3BNTKqybYVDTe8Q@mail.gmail.com
Whole thread
In response to Re: REPACK (CONCURRENTLY) might keep dropped-column data  (Alvaro Herrera <alvherre@kurilemu.de>)
List pgsql-hackers
On Mon, Oct 5, 2026 at 8:35 PM Alvaro Herrera <alvherre@kurilemu.de> wrote:
> I think the repeated creating/dropping is a bit wasteful though and we
> don't need it.  Wouldn't it make more sense to have all tests use CREATE
> IF NOT EXISTS and then remove all the DROPs of it?  We would end up
> having the extension after the tests are run, but since the database is
> specifically created to run the isolation tests, it's not a problem if
> it remains there.  The attached patch would do that.  (I am proposing
> this change just for pg20.)

+1

-# A foreign key check racing a rebuild of the index it resolves through.
 #
 # Pause the RI fast path before it locks the referenced table, allowing

Removing the first line of the comment seems unnecessary?

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: shihao zhong
Date:
Subject: Re: [PG19] eager aggregation gives wrong results because of bpchar_ops
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: Fix apply worker crash when subscriber table has only a deferrable primary key