Hello,
On 2026-Oct-05, Fujii Masao wrote:
> repack_dropped isolation test should also be listed in Makefile, in
> addition to meson.build?
Oh, right.
> +teardown {
> + DROP TABLE repack_dropped;
> + DROP FUNCTION repack_dropped_f;
> +}
>
> Should teardown also drop the injection_points extension created by
> setup, as the other tests that create the injection_points extension
> do?
>
> This missing DROP seems harmless with the current Meson test order, since
> repack_missingval runs next, uses CREATE EXTENSION IF NOT EXISTS, and
> then drops the extension. However, that seems fragile.
Hmm, agreed, let's do this also.
I think the repeated creating/dropping is a bit wasteful though and we
don't need it. Wouldn't it make more sense to have all tests use CREATE
IF NOT EXISTS and then remove all the DROPs of it? We would end up
having the extension after the tests are run, but since the database is
specifically created to run the isolation tests, it's not a problem if
it remains there. The attached patch would do that. (I am proposing
this change just for pg20.)
Thanks!
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
