Postgres Pro
Downloads
Home   >   mailing lists

Re: Your review of pg_receivexlog/pg_basebackup - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Your review of pg_receivexlog/pg_basebackup
Date
Msg-id CAHGQGwE3DL1QO39rga2R0=Dw5xEWKUa6B6OYAjsaTY4GAHEXPQ@mail.gmail.com
Whole thread Raw
In response to Re: Your review of pg_receivexlog/pg_basebackup  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Your review of pg_receivexlog/pg_basebackup
List pgsql-hackers
Tree view 
On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander <magnus@hagander.net> wrote:
> Here's a version that does this. Turns out this requires a lot less
> code than what was previously in there, which is always nice.
>
> We still need to solve the other part which is how to deal with the
> partial files on restore. But this is definitely a cleaner way from a
> pure pg_receivexlog perspective.
>
> Comments/reviews?

Looks good.

Minor comment:
the source code comment of FindStreamingStart() seems to need to be updated.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_upgrade if 'postgres' database is dropped
Next
From: Fujii Masao
Date:
Subject: Re: Updated version of pg_receivexlog