On Wed, Jan 14, 2015 at 11:04 AM, Ali Akbar <the.apaan@gmail.com> wrote:
>
> 2014-12-18 19:35 GMT+07:00 Fujii Masao <masao.fujii@gmail.com>:
>>
>> On Mon, Dec 15, 2014 at 2:38 PM, Andrew Gierth
>> <andrew@tao11.riddles.org.uk> wrote:
>> > I was thinking something like this, added just after that para:
>> >
>> > <warning>
>> > <para>
>> > While the actual arguments to the function remain unchanged
>> > between
>> > calls, if you detoast the argument values (which is normally done
>> > transparently by the
>> > <function>PG_GETARG_<replaceable>xxx</replaceable></function>
>> > macro)
>> > in the transient context then the detoasted copies will be freed
>> > on
>> > each cycle. Accordingly, if you keep references to such values in
>> > your <structfield>user_fctx</>, you must either copy them into the
>> > <structfield>multi_call_memory_ctx</> after detoasting, or ensure
>> > that you detoast the values only in that context.
>> > </para>
>> > </warning>
>>
>> I'm OK with this.
>
>
> Wrapping the doc changes in a patch. Will add to next commitfest so it won't
> be lost.
Pushed. Thanks!
Regards,
--
Fujii Masao