Re: pg_receivexlog and replication slots - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pg_receivexlog and replication slots
Date
Msg-id CAHGQGwE+3Z2o1yZYji8JLTvGHzj9ymKXTmTEHPv==39SNr0FrQ@mail.gmail.com
Whole thread Raw
In response to Re: pg_receivexlog and replication slots  (Andres Freund <andres@2ndquadrant.com>)
Responses Re: pg_receivexlog and replication slots
List pgsql-hackers
On Tue, Aug 19, 2014 at 5:52 PM, Andres Freund <andres@2ndquadrant.com> wrote:
> On 2014-08-18 14:38:06 +0900, Michael Paquier wrote:
>> - IDENTIFY_SYSTEM checks were incorrect (even in HEAD). The following
>> check was done but in 9.4 this command returns 4 fields:
>> (PQntuples(res) != 1 || PQnfields(res) < 3)
>
> Which is correct. We don't want to error out in the case where 3 columns
> are returned because that'd unnecessarily break compatibility with <
> 9.4. Previously that check was != 3...
>
> This isn't a bug.

Okay, I understood why you didn't update those codes.

Since we don't allow replication between different major versions,
it's better to apply this change at least into libpqwalreceiver.c. Thought?

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pg_receivexlog and replication slots
Next
From: Andres Freund
Date:
Subject: Re: pg_receivexlog and replication slots