Re: postgresql 11 release notes - Mailing list pgsql-docs

2018-06-15 7:58 GMT-03:00 Brad DeJong <bpd0018@gmail.com>:
> same patch but renamed to match the patch file naming convention
>
Comments above:

        <para>
-        Previously super users were exclusively granted to access these
+        Previously, super-users were exclusively granted access to these
         functions.
        </para>

The terminology used in the documentation is "superuser".

        <para>
         The new unit is "B".  This is in addition to "kB", "MB", "GB"
-        and "TB", which were accepted previously.
+        and "TB", which are already allowed.
        </para>

I would replace only "were" by "are": "which are accepted previously".

        <para>
-        Exclude unlogged, temporary tables, and
+        Exclude unlogged, temporary tables and
         <filename>pg_internal.init</filename> files from streaming base
         backups (David Steele)
        </para>

AFAIK postgres uses Oxford comma a lot.

        <para>
         Also, if any table mentioned in <command>VACUUM</command> uses
-        a column list, then <command>ANALYZE</command> keyword must be
-        supplied;  previously <command>ANALYZE</command> was implied in
+        a column list, then the <command>ANALYZE</command> keyword must be
+        supplied. Previously, <command>ANALYZE</command> was implied in
         such cases.
        </para>

I prefer to maintain semicolon and add a comma after "previously".

        <para>
-        This allows <application>psql</application>'s default pager to
-        be specified as a separate environment variable from the pager
-        for other applications.  <envar>PAGER</envar> is still honored
-        if <envar>PSQL_PAGER</envar> is not set.
+        In addition to <application>psql</application>, other applications
+        use the <envar>PAGER</envar> environment variable. Having
+        <envar>PSQL_PAGER</envar> as a separate environment variable allows
+        you to use one pager for those applications and a different pager
+        for <application>psql</application>. <application>psql</application>
+        will still honor <envar>PAGER</envar> if <envar>PSQL_PAGER</envar>
+        is not set.
        </para>

I don't see this as an improvement.

        <para>
-        Add ability to suppress dumping and restoring of comments
+        Add an option to suppress dumping and restoring of comments
         (Robins Tharakan)
        </para>

I would suggest "Add an option to suppress dumping and restoring comments".


-- 
   Euler Taveira                                   Timbira -
http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento