Re: fsync error handling in pg_receivewal, pg_recvlogical - Mailing list pgsql-hackers

From Sehrope Sarkuni
Subject Re: fsync error handling in pg_receivewal, pg_recvlogical
Date
Msg-id CAH7T-artawnBt4=KODNCD8Mt2ZX4CCjJT8c=_=950xjutcRZ4Q@mail.gmail.com
Whole thread Raw
In response to Re: fsync error handling in pg_receivewal, pg_recvlogical  (Sehrope Sarkuni <sehrope@jackdb.com>)
Responses Re: fsync error handling in pg_receivewal, pg_recvlogical  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
While reviewing this patch I read through some of the other fsync
callsites and noticed this typo (walkdir is in file_utils.c, not
initdb.c) too:

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 315c74c745..9b79df2d7f 100644
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -3208,7 +3208,7 @@ SyncDataDirectory(void)
  *
  * Errors are reported at level elevel, which might be ERROR or less.
  *
- * See also walkdir in initdb.c, which is a frontend version of this logic.
+ * See also walkdir in file_utils.c, which is a frontend version of this logic.
  */
 static void
 walkdir(const char *path,

Regards,
-- Sehrope Sarkuni
Founder & CEO | JackDB, Inc. | https://www.jackdb.com/



pgsql-hackers by date:

Previous
From: Sehrope Sarkuni
Date:
Subject: Re: fsync error handling in pg_receivewal, pg_recvlogical
Next
From: Bruce Momjian
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)