Postgres Pro
Downloads
Home   >   mailing lists

Re: Proposal to provide the facility to set binary format output for specific OID's per session - Mailing list pgsql-hackers

From Sehrope Sarkuni
Subject Re: Proposal to provide the facility to set binary format output for specific OID's per session
Date
Msg-id CAH7T-arqow+s_RE7ap0VNftSUtY_EOWY5sfnZE7ksMrD6cXXsg@mail.gmail.com
Whole thread Raw
In response to Re: Proposal to provide the facility to set binary format output for specific OID's per session  (Joe Conway <mail@joeconway.com>)
Responses Re: Proposal to provide the facility to set binary format output for specific OID's per session
List pgsql-hackers
Tree view
Idea here makes sense and I've seen this brought up repeatedly on the JDBC lists.

Does the driver need to be aware that this SET command was executed? I'm wondering what happens if an end user executes this with an OID the driver does not actually know how to handle.

> + Oid *tmpOids = palloc(length+1);
> ...
> + tmpOids = repalloc(tmpOids, length+1);

These should be: sizeof(Oid) * (length + 1)

Also, I think you need to specify an explicit context via MemoryContextAlloc or the allocated memory will be in the default context and released at the end of the command.

Regards,
-- Sehrope Sarkuni
Founder & CEO | JackDB, Inc. | https://www.jackdb.com/

pgsql-hackers by date:

Previous
From: Nikita Malakhov
Date:
Subject: Re: Pluggable toaster
Next
From: Dave Cramer
Date:
Subject: Re: Proposal to provide the facility to set binary format output for specific OID's per session