Re: Improve UX of YUM/DNF download form - Mailing list pgsql-www

From Sehrope Sarkuni
Subject Re: Improve UX of YUM/DNF download form
Date
Msg-id CAH7T-aoUB9xZ+TGCjQQ1sJU0_PknzsAqipqs3dy3Tv9b91UMYA@mail.gmail.com
Whole thread Raw
In response to Re: Improve UX of YUM/DNF download form  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Improve UX of YUM/DNF download form  (Dave Page <dpage@pgadmin.org>)
List pgsql-www
I took a peek at the updated yum.js. There's a couple unused variables in the script generation and it doesn't escape the generated text before assigning it to the DOM node. Not an issue now as there's nothing that'd break it, but if it's ever updated to include a redirect ("<") or something else hokey it'd break.

How about the attached?  It splits the script generation into its own function returning a string and has the archChanged() only handle updating the DOM. It uses jQuery .text(...) for the DOM update so that the contents are escaped.

I don't have the full site running locally but adding the new DOM node and copy / pasting in the browser to manipulate the live site with this code seems to work fine.

Regards,
-- Sehrope Sarkuni
Founder & CEO | JackDB, Inc. | https://www.jackdb.com/

Attachment

pgsql-www by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Improve UX of YUM/DNF download form
Next
From: Dave Page
Date:
Subject: Re: Improve UX of YUM/DNF download form