Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names - Mailing list pgsql-bugs

From Euler Taveira
Subject Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names
Date
Msg-id CAH503wCS_XAQkFtH5xFeiL52tQpYc_qRbdFt3X-e8vfUP9pMdA@mail.gmail.com
Whole thread Raw
In response to BUG #16502: EXPLAIN JSON format adds extra quotes around index names  (PG Bug reporting form <noreply@postgresql.org>)
Responses Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Thu, 18 Jun 2020 at 16:50, PG Bug reporting form <noreply@postgresql.org> wrote:

I ran into this in 12.3, but it looks like it's still the case in HEAD. It
looks like this is because `explain_get_index_name` in `explain.c` always
quotes the index name, regardless of the format being used. I'd send a
patch, but I'm not sure how `explain_get_index_name_hook` should fit into
this.


Indeed, relation names should return the same. The fact that explain_get_index_name always calls quote_identifier is the culprit; it should call quote_identifier only when the format is TEXT. Patch is attached. I'm not sure if it should be backpatched to released versions because there should be applications that rely on this format. However, it would be good to backpatch it to v13 too.


--
Euler Taveira                 http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment

pgsql-bugs by date:

Previous
From: Tom Lane
Date:
Subject: Re: BUG #16504: Wrapping query in EXISTS() causes sequential scans of tables
Next
From: Tom Lane
Date:
Subject: Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index names