Re: Column Filtering in Logical Replication - Mailing list pgsql-hackers

From Rahila Syed
Subject Re: Column Filtering in Logical Replication
Date
Msg-id CAH2L28voj+QXjgrXFkcuBf938SYRs5qv8VFtdd+HKaoqXBT3GA@mail.gmail.com
Whole thread Raw
In response to Re: Column Filtering in Logical Replication  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Column Filtering in Logical Replication  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
Hi,
 

I don't think there is one.  I think the latest is what I posted in
https://postgr.es/m/202109061751.3qz5xpugwx6w@alvherre.pgsql (At least I
don't see any reply from Rahila with attachments after that), but that
wasn't addressing a bunch of review comments that had been made; and I
suspect that Amit K has already committed a few conflicting patches
after that.

Yes, the v5 version of the patch attached by Alvaro is the latest one. 
IIUC, the review comments that are yet to be addressed apart from the ongoing grammar 
discussion, are as follows:

1. Behaviour on dropping a column from the table, that is a part of column filter.
In the latest patch, the entire table is dropped from publication on dropping a column
that is a part of the column filter. However, there is preference for another approach
to drop just the column from the filter on DROP column CASCADE(continue to filter
the other columns), and an error for DROP RESTRICT. 

2. Instead of WITH RECURSIVE query to find the topmost parent of the partition
in fetch_remote_table_info, use pg_partition_tree and pg_partition_root.

3. Report of memory leakage in get_rel_sync_entry().

4. Missing documentation

5. Latest comments(last two messages) by Peter Smith.

Thank you,
Rahila Syed

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Column Filtering in Logical Replication
Next
From: Alvaro Herrera
Date:
Subject: Re: PostgreSQL High Precision Mathematics Extension.