Re: add function for creating/attaching hash table in DSM registry - Mailing list pgsql-hackers

From Rahila Syed
Subject Re: add function for creating/attaching hash table in DSM registry
Date
Msg-id CAH2L28sjQ5Vv6YrCYUtH9A1La55s53EKeHMWfMPN71ijKQhj-g@mail.gmail.com
Whole thread Raw
In response to Re: add function for creating/attaching hash table in DSM registry  (Florents Tselai <florents.tselai@gmail.com>)
Responses Re: add function for creating/attaching hash table in DSM registry
List pgsql-hackers
Hi,


Here is what I have staged for commit.

 
Thank you for sharing the updated patch.
This looks good to me. I used the GetNamedDSA added by this patch in my code and it worked fine.
           
 /* XXX: Should we verify params matches what table was created with? */

Are you planning to address the above before you commit?  It seems like a helpful check since GetNamedDshash
takes the params as arguments. That said, I don't have a strong preference either way.

 I have a question: is there a way to remove the entries from the registry and free the space?
 For example, if a user decides to call dshash_destroy the dshash entry in the registry would no longer be needed.

Thank you,
Rahila Syed

pgsql-hackers by date:

Previous
From: torikoshia
Date:
Subject: Re: speedup COPY TO for partitioned table.
Next
From: Peter Eisentraut
Date:
Subject: Re: doc: Some copy-editing around prefix operators