On Thu, Jan 10, 2019 at 1:15 PM Robert Haas <robertmhaas@gmail.com> wrote:
> I feel like there has been some other thread where this was discussed,
> but I can't find it right now. I think that the "query construction"
> logic in transformMergeStmt is fundamentally the wrong way to do this.
> I think several others have said the same. And I don't think this
> should be considered for commit until that is rewritten.
I agree with that.
I think that it's worth acknowledging that Pavan is in a difficult
position with this patch. As things stand, Pavan really needs input
from a couple of people to put the query construction stuff on the
right path, and that input has not been forthcoming. I'm not
suggesting that anybody has failed to meet an obligation to Pavan to
put time in here, or that anybody has suggested that this is down to a
failure on Pavan's part. I'm merely pointing out that Pavan is in an
unenviable position with this patch, through no fault of his own, and
despite a worthy effort.
I hope that he sticks it out, because that seems to be what it takes
to see something like this through. I don't know how to do better at
that.
--
Peter Geoghegan
