Re: Yet another fast GiST build - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Yet another fast GiST build
Date
Msg-id CAH2-WznnqS7HcPhT5F-vFY82iBe4c6eboKB044Tc1N2bWRzuXw@mail.gmail.com
Whole thread Raw
In response to Re: Yet another fast GiST build  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Yet another fast GiST build  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On Sun, Jan 17, 2021 at 12:50 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I noticed that gist_page_items() thinks it can hold inter_call_data->rel
> open across a series of calls.  That's completely unsafe: the executor
> might not run the call series to completion (see LIMIT), resulting in
> relcache leak complaints.

It also has the potential to run into big problems should the user
input a raw page image with an regclass-argument-incompatible tuple
descriptor. Maybe that's okay (this is a tool for experts), but it
certainly is a consideration.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: pg_collation_actual_version() ERROR: cache lookup failed for collation 123
Next
From: Vik Fearing
Date:
Subject: Re: WIP: System Versioned Temporal Table