Re: Fix for pageinspect bug in PG 17 - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Fix for pageinspect bug in PG 17
Date
Msg-id CAH2-WzniX+CJWoLGjnPJFfzwYcStGswcv6RTzFcuQoYWxMzvWg@mail.gmail.com
Whole thread Raw
In response to RE: Fix for pageinspect bug in PG 17  ("Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>)
List pgsql-hackers
On Wed, Nov 13, 2024 at 7:48 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Nov 13, 2024 at 09:00:30PM +0100, Tomas Vondra wrote:
> > Does that mean you think we should fix the issue at hand differently?
> > Say, by looking at number of columns and building the correct tuple,
> > like I did in my initial patch?
>
> 691e8b2e18 is not something I would have done when it comes to
> pageinspect, FWIW.  There is the superuser argument for this module,
> so I'd vote for an error and apply the same policy across all branches
> as a matter of consistency.

691e8b2e18 was the one that threw the error?

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Next
From: Peter Geoghegan
Date:
Subject: Re: Fix for pageinspect bug in PG 17