Postgres Pro
Downloads
Home   >   mailing lists

Re: More reliable nbtree detection of unsatisfiable RowCompare quals involving a leading NULL key/element - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: More reliable nbtree detection of unsatisfiable RowCompare quals involving a leading NULL key/element
Date
Msg-id CAH2-WznQFCfJsxCt2yOMZ1SrHUfHN-32aVXSLvb-7pPsRt=9QA@mail.gmail.com
Whole thread Raw
In response to Re: More reliable nbtree detection of unsatisfiable RowCompare quals involving a leading NULL key/element  (Matthias van de Meent <boekewurm+postgres@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Jan 7, 2025 at 7:58 AM Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
> This doesn't really clarify _why_ we'd never get this far, so I'd word that as
>
> +             * Cannot be a NULL in the first row member: _bt_preprocess_keys
> +             * would've marked the qual as unsatisfyable, preventing us from
> +             * ever getting this far.
>
> Apart from that minor issue, LGTM.

Pushed this just now. I used your suggested wording in the committed patch.

Thanks for the review!

--
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Further _bt_first simplifications for parallel index scans
Next
From: Bertrand Drouvot
Date:
Subject: Re: PoC: history of recent vacuum/checkpoint runs (using new hooks)