Re: [PATCH] Full support for index LP_DEAD hint bits on standby - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: [PATCH] Full support for index LP_DEAD hint bits on standby
Date
Msg-id CAH2-WznMimF3z0Ab1rTfMLeveBZUUUqa-WAnY6EYP301ZpE=FA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Full support for index LP_DEAD hint bits on standby  (Michail Nikolaev <michail.nikolaev@gmail.com>)
List pgsql-hackers
On Thu, Mar 31, 2022 at 4:57 PM Michail Nikolaev
<michail.nikolaev@gmail.com> wrote:
> I remember you had an idea about using the LP_REDIRECT bit in btree
> indexes as some kind of “recently dead” flag (1).
> Is this idea still in progress? Maybe an additional bit could provide
> a space for a better solution.

I think that the best way to make the patch closer to being
committable is to make the on-disk representation more explicit.
Relying on an implicit or contextual definition for anything seems
like something to avoid. This is probably the single biggest problem
that I see with the patch.

I suggest that you try to "work backwards". If the patch was already
committed today, but had subtle bugs, then how would we be able to
identify the bugs relatively easily? What would our strategy be then?

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Zhihong Yu
Date:
Subject: Re: generic plans and "initial" pruning
Next
From: Richard Guo
Date:
Subject: Re: MERGE bug report