Postgres Pro
Downloads
Home   >   mailing lists

Re: PageGetFreeSpace() isn't quite the right thing for some of its callers - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: PageGetFreeSpace() isn't quite the right thing for some of its callers
Date
Msg-id CAH2-Wzn82-H5Xbe5P898rLp6Y_6=wrjxEfBXwP133j32aVuvUQ@mail.gmail.com
Whole thread Raw
In response to Re: PageGetFreeSpace() isn't quite the right thing for some of its callers  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Apr 9, 2019 at 11:35 AM Robert Haas <robertmhaas@gmail.com> wrote:
> Maybe we should rename it.

There are only about 20 PageGetFreeSpace() callers, so that shouldn't
be too disruptive. We might also need to rename
PageGetFreeSpaceForMultipleTuples() and PageGetExactFreeSpace(). And,
heapam.c won't be able to call whatever we rename PageGetFreeSpace()
to.

-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pg_dump is broken for partition tablespaces
Next
From: Ashwin Agrawal
Date:
Subject: Re: Zedstore - compressed in-core columnar storage