Re: Allow cancelling VACUUM of nbtrees with corrupted right links - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Allow cancelling VACUUM of nbtrees with corrupted right links
Date
Msg-id CAH2-Wzn6FL4SC5oo=1_PwiBoPGiTmk1nyuvOueWbPt3SoNQz=g@mail.gmail.com
Whole thread Raw
In response to Re: Allow cancelling VACUUM of nbtrees with corrupted right links  (Andres Freund <andres@anarazel.de>)
Responses Re: Allow cancelling VACUUM of nbtrees with corrupted right links
List pgsql-hackers
On Wed, Jun 27, 2018 at 12:52 PM, Andres Freund <andres@anarazel.de> wrote:
> A related question is if it matters - without complicating the code I
> don't see how we could release all the locks in that loop. Therefore no
> interrupts can be accepted.  I hope I'm missing something?

I agree.

In general, page deletion is the most complicated part of nbtree
concurrency, by far (if we just had the basic L&Y, the concurrency
aspects would be far easier to grasp). Doing better in
_bt_unlink_halfdead_page() seems extremely difficult, and very
unlikely to be worthwhile.

-- 
Peter Geoghegan


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Allow cancelling VACUUM of nbtrees with corrupted right links
Next
From: Justin Pryzby
Date:
Subject: Re: adding tab completions