Re: A qsort template - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: A qsort template
Date
Msg-id CAH2-WzmpOqjHDoSnN1REHB+X6SELQeM36JituowfG1SBJAYpVQ@mail.gmail.com
Whole thread Raw
In response to Re: A qsort template  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: A qsort template
List pgsql-hackers
On Fri, Jul 30, 2021 at 3:34 AM John Naylor
<john.naylor@enterprisedb.com> wrote:
> I'm also attaching your tuplesort patch so others can see what exactly I'm comparing.

If you're going to specialize the sort routine for unsigned integer
style abbreviated keys then you might as well cover all relevant
opclasses/types. Almost all abbreviated key schemes produce
conditioned datums that are designed to use simple 3-way unsigned int
comparator. It's not just text. (Actually, the only abbreviated key
scheme that doesn't do it that way is numeric.)

Offhand I know that UUID, macaddr, and inet all have abbreviated keys
that can use your new ssup_datum_binary_cmp() comparator instead of
their own duplicated comparator (which will make them use the
corresponding specialized sort routine inside tuplesort.c).

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Record a Bitmapset of non-pruned partitions
Next
From: Richard Guo
Date:
Subject: Re: Problem about postponing gathering partial paths for topmost scan/join rel