Re: BTMaxItemSize seems to be subtly incorrect - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: BTMaxItemSize seems to be subtly incorrect
Date
Msg-id CAH2-Wzm_dbQLOmpxymmTg-CK7wgxPjd7c2hxrZafjtwLHXq8WQ@mail.gmail.com
Whole thread Raw
In response to Re: BTMaxItemSize seems to be subtly incorrect  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Fri, Aug 5, 2022 at 10:13 AM Peter Geoghegan <pg@bowt.ie> wrote:
> Update: I discovered that I can get the regression tests to fail (even
> on mainstream 64-bit platforms) by MAXALIGN()'ing the expression that
> we assign to state->maxpostingsize at the top of _bt_dedup_pass().

Looks like this was nothing more than a silly oversight with how the
macro was defined. As written, it would evaluate to the wrong thing at
the same point in nbtdedup.c, just because it was used in an
expression.

Pushed a fix for that just now.
-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: David Zhang
Date:
Subject: Re: Hash index build performance tweak from sorting
Next
From: Nathan Bossart
Date:
Subject: Re: optimize lookups in snapshot [sub]xip arrays