Re: Intermittent buildfarm failures on wrasse - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Intermittent buildfarm failures on wrasse
Date
Msg-id CAH2-WzmOJ5YeT1SsBZ7kp2B+EMMVH9RYShornT13oyduEVwKSw@mail.gmail.com
Whole thread Raw
In response to Re: Intermittent buildfarm failures on wrasse  (Andres Freund <andres@anarazel.de>)
Responses Re: Intermittent buildfarm failures on wrasse
List pgsql-hackers
On Wed, Apr 13, 2022 at 4:13 PM Andres Freund <andres@anarazel.de> wrote:
> IIRC the problem in matter isn't skipped pages, but that the horizon simply isn't new enough to mark pages as all
visible.

Sometimes OldestXmin can go backwards in VACUUM operations that are
run in close succession against the same table, due to activity from
other databases in the same cluster (perhaps other factors are
involved at times).

That's why the following assertion that I recently added to
vacuumlazy.c will fail pretty quickly without the
"vacrel->NewRelfrozenXid == OldestXmin" part of its test:

    Assert(vacrel->NewRelfrozenXid == OldestXmin ||
           TransactionIdPrecedesOrEquals(aggressive ? FreezeLimit :
                                         vacrel->relfrozenxid,
                                         vacrel->NewRelfrozenXid));

If you remove "vacrel->NewRelfrozenXid == OldestXmin", and run the
regression tests, the remaining assertion will fail quite easily.
Though perhaps not with a serial "make check".

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Intermittent buildfarm failures on wrasse
Next
From: Bruce Momjian
Date:
Subject: Re: Temporary file access API