Re: pgsql: Make heap TID a tiebreaker nbtree index column. - Mailing list pgsql-committers

From Peter Geoghegan
Subject Re: pgsql: Make heap TID a tiebreaker nbtree index column.
Date
Msg-id CAH2-WzmMakut=D8=TnmzhGtB+ELbb6k84LYNW28C8MZ2D-ZoJw@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Make heap TID a tiebreaker nbtree index column.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Make heap TID a tiebreaker nbtree index column.
List pgsql-committers
On Wed, Mar 20, 2019 at 8:17 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Actually, I'm not sure why it would be fine to revert 7d3bf73ac now.
> > Might the problem actually be the order in which OIDs are originally
> > assigned, or something like that?
>
> No, because then things would have been unstable before, no?

Perhaps. The cost of being wrong here is trivial anyway. I have
reverted 7d3bf73ac based on the assumption that it's now unnecessary.

> I actually think that we should remove most or all of the
> cascade-drop-hiding hacks that are in the regression tests now,
> not only that one.  They should not be necessary any more, and
> they might be hiding things we need to know about, now or in
> the future.  But I haven't got round to it.

Seems like a useful goal.

-- 
Peter Geoghegan


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: pgsql: Revert "Suppress DETAIL output from a foreign_data test."
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of apartition