Re: ON CONFLICT DO UPDATE for partitioned tables - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: ON CONFLICT DO UPDATE for partitioned tables
Date
Msg-id CAH2-WzmMSyzP08mEKZ5qCM2oPu74a4z1qqQ+_Fk=8huerqODfQ@mail.gmail.com
Whole thread Raw
In response to Re: ON CONFLICT DO UPDATE for partitioned tables  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: ON CONFLICT DO UPDATE for partitioned tables  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
On Fri, Mar 16, 2018 at 11:21 AM, Alvaro Herrera
<alvherre@alvh.no-ip.org> wrote:
> So ExecInsert receives the ModifyTableState, and separately it receives
> arbiterIndexes and the OnConflictAction, both of which are members of
> the passed ModifyTableState.  I wonder why does it do that; wouldn't it
> be simpler to extract those members from the node?

> Or is there another reason to pass the index list?

It works that way pretty much by accident, as far as I can tell.
Removing the two extra arguments sounds like a good idea.

-- 
Peter Geoghegan


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables
Next
From: Andres Freund
Date:
Subject: Update doc links to https where appropriate?