Re: nbtree's ScalarArrayOp array mark/restore code appears to be buggy - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: nbtree's ScalarArrayOp array mark/restore code appears to be buggy
Date
Msg-id CAH2-WzmLkUO7yCGC=hsxxWcsEO4JXj=begNYeRt+YNFjFLDm2A@mail.gmail.com
Whole thread Raw
In response to Re: nbtree's ScalarArrayOp array mark/restore code appears to be buggy  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Sat, Sep 23, 2023 at 4:22 PM Peter Geoghegan <pg@bowt.ie> wrote:
> Attached draft patch shows how this could work.
>
> _bt_restore_array_keys() has comments that seem to suppose that
> calling _bt_preprocess_keys is fairly expensive, and something that's
> well worth avoiding. But...is it, really? I wonder if we'd be better
> off just biting the bullet and always calling _bt_preprocess_keys
> here.

My current plan is to commit something close to my original patch on
Wednesday or Thursday. My proposed fix is minimally invasive (it still
allows _bt_restore_array_keys to avoid most calls to
_bt_preprocess_keys), so I don't see any reason to delay acting here.

--
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: XLog size reductions: smaller XLRec block header for PG17
Next
From: Robert Haas
Date:
Subject: Re: CREATE FUNCTION ... SEARCH { DEFAULT | SYSTEM | SESSION }