Re: PANIC: wrong buffer passed to visibilitymap_clear - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: PANIC: wrong buffer passed to visibilitymap_clear
Date
Msg-id CAH2-WzmJ7THDU3jPgRH8J++b+pSoOh8nfGZEhNHh+4=LFatDeg@mail.gmail.com
Whole thread Raw
In response to Re: PANIC: wrong buffer passed to visibilitymap_clear  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: PANIC: wrong buffer passed to visibilitymap_clear  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
On Sun, Apr 11, 2021 at 8:57 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Does this patch seem to fix the problem?
>
> Hmm ... that looks pretty suspicious, I agree, but why wouldn't an
> exclusive buffer lock be enough to prevent concurrency with heap_update?

I don't have any reason to believe that using a super-exclusive lock
during heap page vacuuming is necessary. My guess is that returning to
doing it that way might make the buildfarm green again. That would at
least confirm my suspicion that this code is relevant. The
super-exclusive lock might have been masking the problem for a long
time.

How about temporarily committing this patch, just to review how it
affects the buildfarm?

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PANIC: wrong buffer passed to visibilitymap_clear
Next
From: Tom Lane
Date:
Subject: Re: psql - add SHOW_ALL_RESULTS option