pg_waldump/heapdesc.c and struct field names - Mailing list pgsql-hackers

From Peter Geoghegan
Subject pg_waldump/heapdesc.c and struct field names
Date
Msg-id CAH2-Wzkt_Rs4VqPSCk87nyjPAAEmWL8STU9zgET_83EF5YfrLw@mail.gmail.com
Whole thread Raw
Responses Re: pg_waldump/heapdesc.c and struct field names  (Masahiko Sawada <sawada.mshk@gmail.com>)
Re: pg_waldump/heapdesc.c and struct field names  (Abhijit Menon-Sen <ams@toroid.org>)
Re: pg_waldump/heapdesc.c and struct field names  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
I notice that heapdesc.c outputs the field latestRemovedXid as
"remxid". But why? What sense is there in changing the name for output
by tools like pg_waldump, which are intrinsically internals focussed?

Does anyone have any objections to my changing the details within
heapdesc.c on master, so that pg_waldump will use struct field names?
It doesn't seem necessary to change the output that has spaces instead
of an underscore, or something like that. It just seems worth removing
gratuitous inconsistencies, such as this one.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Test harness for regex code (to allow importing Tcl's test suite)
Next
From: Masahiko Sawada
Date:
Subject: Re: pg_waldump/heapdesc.c and struct field names