Postgres Pro
Downloads
Home   >   mailing lists

Re: old_snapshot_threshold bottleneck on replica - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: old_snapshot_threshold bottleneck on replica
Date
Msg-id CAH2-WzktQMRbJRKxvs+haY8fTH+zW+PyyoKewuHzQr=uY+AR=A@mail.gmail.com
Whole thread Raw
In response to Re: old_snapshot_threshold bottleneck on replica  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: old_snapshot_threshold bottleneck on replica
List pgsql-hackers
Tree view 
On Thu, Sep 7, 2023 at 8:49 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> The code moved around quite a few times over several commits and quite
> a lot since then, which is why I didn't go for straight revert, but
> clearly the manual approach risked missing things.

It's not a big deal, obviously.

> I think the
> attached removes all unused 'snapshot' arguments from AM-internal
> functions.  Checked by compiling with clang's -Wunused-parameters, and
> then searching for 'snapshot', and excluding the expected cases.

This looks right to me.

Thanks
--
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Document that server will start even if it's unable to open some TCP/IP ports
Next
From: Jingtang Zhang
Date:
Subject: Suspicious redundant assignment in COPY FROM