Re: heap_abort_speculative() sets xmin to Invalid* without HEAP_XMIN_INVALID - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: heap_abort_speculative() sets xmin to Invalid* without HEAP_XMIN_INVALID
Date
Msg-id CAH2-Wzkpiu7FVCeLY+TTm97-xrLRmb9uvNkBkg+K0XwSkyaC+g@mail.gmail.com
Whole thread Raw
In response to Re: heap_abort_speculative() sets xmin to Invalid* without HEAP_XMIN_INVALID  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Thu, Jul 23, 2020 at 2:49 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> On 2020-Jul-23, Andres Freund wrote:
>
> > I think we should change heap_abort_speculative() to set
> > HEAP_XMIN_INVALID in master.
>
> +1

+1

> +1 for doing it as an additional fix, with a fat comment somewhere
> explaining where such tuples would come from.

There could be an opportunity to put this on a formal footing by doing
something in the amcheck heap checker patch.

-- 
Peter Geoghegan



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Making CASE error handling less surprising
Next
From: Amul Sul
Date:
Subject: Re: [Patch] ALTER SYSTEM READ ONLY